Ensure MG to have the same number of allreduce calls in mean_stddev for sparse matrix to avoid hanging#6141
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.12from Dec 6, 2024
Conversation
lijinf2
added
improvement
lijinf2
force-pushed
the
fix_hanging_mean_stddev
branch
from
6c56fa1 to
21be3fb
Compare
lijinf2
added
3 - Ready for Review
lijinf2
force-pushed
the
fix_hanging_mean_stddev
branch
from
21be3fb to
83ca352
Compare
Contributor
Author
|
build |
lijinf2
force-pushed
the
fix_hanging_mean_stddev
branch
from
83ca352 to
f87fab6
Compare
lijinf2
added
3 - Ready for Review
lijinf2
force-pushed
the
fix_hanging_mean_stddev
branch
from
f87fab6 to
dabf335
Compare
Contributor
Author
|
Added test cases to test_dask_logistic_regression.py for better testing. No change to the main code (standardization.cuh). Ready for review. |
add the testcase of one GPU gets all zeroes revise test_standardization_example to reuse functions keep revise to reuse code give a better name
lijinf2
force-pushed
the
fix_hanging_mean_stddev
branch
from
6affb8a to
90d7df5
Compare
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hanging occurs when one GPU gets a sparse matrix of all zero values, while other GPUs get-zero values.