Fix Dask estimators serialization prior to training#6065
Merged
rapids-bot[bot] merged 4 commits intobranch-24.12from Oct 17, 2024
Merged
Fix Dask estimators serialization prior to training#6065rapids-bot[bot] merged 4 commits intobranch-24.12from
rapids-bot[bot] merged 4 commits intobranch-24.12from
Conversation
divyegala
reviewed
Sep 10, 2024
Member
divyegala
left a comment
There was a problem hiding this comment.
Can we add a tiny test to make sure that the serialization and deserialization are both successful for un-trained models? Maybe also train the model after deserialization
Member
|
@viclafargue seems like the test ran into an issue in the pytest in some jobs: =================================== FAILURES ===================================
________________________ test_serialize_before_training ________________________
client = <Client: 'tcp://127.0.0.1:45687' processes=1 threads=1, memory=251.77 GiB>
def test_serialize_before_training(client):
X, y = make_regression(n_samples=1000, n_features=20, random_state=0)
X, y = da.from_array(X), da.from_array(y)
model = LinearRegression(client=client)
> pickled_model = pickle.dumps(model)
test_dask_serialization.py:90:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <cuml.dask.linear_model.linear_regression.LinearRegression object at 0x7fca696b4510>
def __getstate__(self):
> internal_model = self._get_internal_model().result()
E AttributeError: 'NoneType' object has no attribute 'result'
/opt/conda/envs/test/lib/python3.11/site-packages/cuml/dask/common/base.py:60: AttributeError |
Contributor
Author
That's really strange, might possibly be missing something, but isn't there an issue with the CI? |
divyegala
approved these changes
Oct 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-24.12 #6065 +/- ##
================================================
- Coverage 68.33% 67.15% -1.18%
================================================
Files 193 193
Lines 12837 12839 +2
================================================
- Hits 8772 8622 -150
- Misses 4065 4217 +152 ☔ View full report in Codecov by Sentry. |
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially answers #6046