Skip to content

Fix RandomForestClassifier return type#5896

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-24.06from
jinsolp:fix-rfclassifier-float
May 23, 2024
Merged

Fix RandomForestClassifier return type#5896
rapids-bot[bot] merged 3 commits intorapidsai:branch-24.06from
jinsolp:fix-rfclassifier-float

Conversation

@jinsolp
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp commented May 17, 2024

Closes #5637

import cuml
from cuml.datasets import make_classification

X, y = make_classification()

clf = cuml.ensemble.RandomForestClassifier().fit(X,y)
print(clf.predict(X[:5]).dtype)

Result is

int64

@jinsolp jinsolp requested a review from a team as a code owner May 17, 2024 23:12
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented May 17, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 17, 2024
@jinsolp jinsolp force-pushed the fix-rfclassifier-float branch from d20cd9b to 0efe136 Compare May 20, 2024 16:29
dantegd
dantegd approved these changes May 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks good to me

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels May 22, 2024
@dantegd
Copy link
Copy Markdown
Member

dantegd commented May 22, 2024

/ok to test

@dantegd
Copy link
Copy Markdown
Member

dantegd commented May 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit 47416d7 into rapidsai:branch-24.06 May 23, 2024
@jinsolp jinsolp deleted the fix-rfclassifier-float branch May 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

No one assigned

Labels

bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] RandomForestClassifier predict returns float rather than integer data (breaking scikit-learn's VotingClassifier)

2 participants

@jinsolp @dantegd