Update cugraph for compatibility with the latest cuco#4111
Update cugraph for compatibility with the latest cuco#4111rapids-bot[bot] merged 16 commits intorapidsai:branch-24.04from
Conversation
PointKernel
changed the title
PointKernel
force-pushed
the
fix-cuco-merge-conflicts
branch
from
7e7d685 to
2db4e84
Compare
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
Besides the minor comments about naming, looks good to me.
seunghwak
added
improvement
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
The pip devcontainer CI failed because cugraph fetches the proper cuco version but it's still using the "main" cudf branch which doesn't include the changes in rapidsai/cudf#14849.
|
PointKernel
changed the title
This PR bumps to the latest cuco version which removes experimental namespace and includes multiple bug fixes. CI must pass on these PRs before we can merge this change: - [ ] rapidsai/cudf#14849 - [ ] rapidsai/cugraph#4111 - [ ] rapidsai/raft#2118 Authors: - Yunsong Wang (https://github.com/PointKernel) - Robert Maynard (https://github.com/robertmaynard) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) URL: #526
…ix-cuco-merge-conflicts
PointKernel
changed the title
|
This is ready to go once CI passes. Note the CI will be blocked until this PR gets merged. Thanks! |
|
Can someone please rerun the failed CI? They should pass this time. |
Still failing. Have the artifacts all been updated? |
I think it's because cugraph is using the cuco version from |
|
@ChuckHastings could you please give it another try? rapidsai/raft#2118 just gets merged. |
|
One of the devcontainer builds (like still getting old packages due to the cuco errors in the log). Restarted that job |
|
This is now passing! 🎉 |
|
Going to go ahead and merge as this was already approved above. We were just waiting on CI. Hope that is ok |
|
/merge |
7 participants
This PR updates cugraph to make it compatible with the latest cuco.
Depends on rapidsai/rapids-cmake#526
CMake changes will be reverted once rapidsai/rapids-cmake#526 is merged.