JNI support for SUM_WITH_OVERFLOW aggregation#22404
Open
mythrocks wants to merge 2 commits intorapidsai:mainfrom
Open
JNI support for SUM_WITH_OVERFLOW aggregation#22404mythrocks wants to merge 2 commits intorapidsai:mainfrom
mythrocks wants to merge 2 commits intorapidsai:mainfrom
Conversation
This commit adds JNI bindings for cudf's SUM_WITH_OVERFLOW aggregation, which returns a struct of {sum, overflow: BOOL8} in a single fused kernel pass.
This mirrors the C++ surface:
1. reduction (INT64 only)
2. hash-based groupby (INT8/16/32/64 + decimal)
3. not exposed for sort groupby, scan, segmented reduce, or rolling, since cudf does not implement those paths.
This should allow us to retire the chunked-sum workaround in `Aggregation64Utils` eventually.
Signed-off-by: MithunR <[email protected]>
mythrocks
force-pushed
the
sum-with-overflow-jni
branch
from
6ae2ff9 to
484fba7
Compare
mythrocks
added
feature request
Contributor
Author
|
cc @paul-aiyedun. |
Signed-off-by: MithunR <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds JNI bindings for cudf's SUM_WITH_OVERFLOW aggregation, which returns a struct of {sum, overflow: BOOL8} in a single fused kernel pass. This mirrors the C++ surface:
This should allow us to retire the chunked-sum workaround in
Aggregation64Utilseventually.Checklist