Update to clang 20#18818
Conversation
bdice
added
non-breaking
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
There are a surprising number of changes in the formatting here, but they do all look like just formatting so I'm OK with that. As long as it's automated I don't mind too much what the formatting does.
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
Could you do a quick check and see if we can also get the clang-tidy version synced up now? That way we don't need a separate environment for cudf for just clang-tidy.
| } // out_ptr ---^ | ||
| last_pos += (match->second - last_pos.position()); // i:bbbbsssseeee | ||
| // in_ptr --^ | ||
| } // out_ptr ---^ |
Updated in abf804c. We'll see if it passes. |
|
Thanks! If it needs more than small changes to resolve I'd be fine breaking that work off into a follow-up to get the original issue unblocked, but hopefully it's not bad. |
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
Thanks! It will make it much easier to improve our clang-tidy setup now that people can use the default version installed into our development environments.
|
/merge |
Similar to [rapidsai/cudf#18818](rapidsai/cudf#18818), this pull request updates the pre-commit clang-format hook to version 20.1.4.
3 participants
Description
Contributes to rapidsai/build-planning#177
This PR updates the clang version to 20.