Remove dataframe protocol#17909
Conversation
|
Hmm darn. Ideally we should have had warnings as errors enabled for cudf pandas tests based on the configs in |
|
Hmm yeah that is unfortunate. We should fix that in a follow-up PR. I don't know that we can reuse existing pyproject.toml files though given the special nature of these tests. Maybe our best bet is to just copy over filters from our other pyprojects? |
|
/merge |
|
I think we will need to investigate the massive increase in duration of On a different pr it is(50 mins): https://github.com/rapidsai/cudf/actions/runs/13120888958/job/36623191308 On this pr it is consistently going beyond (1hr 30mins): https://github.com/rapidsai/cudf/actions/runs/13128280990/job/36670004745?pr=17909 |
I'm investigating what is causing this slowdown. |
|
Maybe not the root of the slowdown, but it appears 2025-02-04T17:07:30.8282675Z [gw2] [ 99%] FAILED tests/io/test_pickle.py::test_pickle_generalurl_read[http://url.com]
2025-02-04T17:36:11.9497790Z tests/io/test_pickle.py::test_pickle_generalurl_read[ftp://test.com] |
|
Marked as do not merge until Prem has a chance to get to the bottom of the perf hit. |
|
/merge |
| PYTEST_IGNORES="--ignore=tests/io/parser/common/test_read_errors.py \ | ||
| --ignore=tests/io/test_clipboard.py" | ||
| --ignore=tests/io/test_clipboard.py \ | ||
| --ignore=tests/io/test_pickle.py" |
Description
Follow-up to #17736
Checklist