fix libcudf wheel publishing, make package-type explicit in wheel publishing#16650
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-24.10from Aug 23, 2024
jameslamb:fix/libcudf-wheel-publishing
Merged
fix libcudf wheel publishing, make package-type explicit in wheel publishing#16650rapids-bot[bot] merged 1 commit intorapidsai:branch-24.10from jameslamb:fix/libcudf-wheel-publishing
rapids-bot[bot] merged 1 commit intorapidsai:branch-24.10from
jameslamb:fix/libcudf-wheel-publishing
Conversation
vyasr
approved these changes
Aug 23, 2024
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
I'd be fan of making this explicit everywhere over the course of the C++ wheels work and eventually making it a required parameter.
KyleFromNVIDIA
approved these changes
Aug 23, 2024
Member
Same here. |
bdice
approved these changes
Aug 23, 2024
Member
Author
|
/merge |
11 tasks
This was referenced Aug 29, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 31, 2024
Follow-up to #16650 and #15483. `libcudf` wheels are identical (same content, same filename) across Python versions, but due to an oversight in the PRs linked above, we're currently building nightlies of them once per Python version supported by RAPIDS 😭 You can see this on recent runs of the `build` workflow: <img width="752" alt="image" src="https://github.com/user-attachments/assets/ba3a2192-1752-4d32-a79b-6f238fae9f18"> ([build link](https://github.com/rapidsai/cudf/actions/runs/10627299703/job/29460218854)) This PR fixes that by applying the same matrix filter to `libcudf` nightly build jobs as is currently applied to PR jobs: https://github.com/rapidsai/cudf/blob/5e420ff63ba2997a37bf5dfbfaa73c5f05225f9d/.github/workflows/pr.yaml#L195-L200 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: #16714
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #15483.
Contributes to rapidsai/build-planning#33
Wheel publishing for
libcudfis failing like this:(build link)
Because the
package-typewas not set tocppin thewheels-publishCI workflow, and that workflow defaults topython. (shared-workflows code link).This fixes that, and makes that choice explicit for all wheel publishing jobs.
References for this
package-typeargument:Checklist