Skip to content

Enable testing cudf.pandas unit tests for all minor versions of pandas#16595

Merged
rapids-bot[bot] merged 43 commits intorapidsai:branch-24.10from
galipremsagar:pandas_minor_ver_ci
Aug 23, 2024
Merged

Enable testing cudf.pandas unit tests for all minor versions of pandas#16595
rapids-bot[bot] merged 43 commits intorapidsai:branch-24.10from
galipremsagar:pandas_minor_ver_ci

Conversation

@galipremsagar
Copy link
Copy Markdown
Contributor

@galipremsagar galipremsagar commented Aug 19, 2024

Description

Fixes: #16537

This PR enables testing cudf.pandas unit tests with all minor versions of pandas-2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 19, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Aug 20, 2024
@galipremsagar galipremsagar changed the title test ci Enable testing cudf.pandas unit tests for all minor versions of pandas Aug 20, 2024
@galipremsagar galipremsagar marked this pull request as ready for review August 20, 2024 16:44
@galipremsagar galipremsagar requested review from a team as code owners August 20, 2024 16:44
seberg added a commit to seberg/cudf that referenced this pull request Aug 21, 2024
Co-authored-by: galipremsagar <sagarprem75@gmail.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@vyasr
Copy link
Copy Markdown
Contributor

vyasr commented Aug 22, 2024

The reason just testing oldest and latest versions would not be sufficient with cudf.pandas is pandas-2.x especially has had multiple breaking changes across minor versions in-between too. That's why this testing.

The main thing is that we want to make sure that cudf.pandas will at least import normally for a wider range of packages. The way that cudf.pandas works, it is much easier to make a change that actually prevents import pandas as pd from working. We're OK if some particular bit of functionality only works with pandas 2.1.2 but not 2.0.1 because we can only realistically match exactly the behavior of one pandas version at a time due to all the edge cases in pandas behavior. We are not OK with a particular pandas version (supposedly within our supported range) being completely unusable.

Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for improvement, otherwise seems fine.

@galipremsagar
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 91f304e into rapidsai:branch-24.10 Aug 23, 2024
@jakirkham jakirkham mentioned this pull request Aug 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[FEA] Add CI job to validate that cudf.pandas can be imported for all supported minor versions of pandas

6 participants