split up CUDA-suffixed dependencies in dependencies.yaml#16183
Merged
rapids-bot[bot] merged 24 commits intorapidsai:branch-24.08from Jul 24, 2024
jameslamb:suffix-split
Merged
split up CUDA-suffixed dependencies in dependencies.yaml#16183rapids-bot[bot] merged 24 commits intorapidsai:branch-24.08from jameslamb:suffix-split
rapids-bot[bot] merged 24 commits intorapidsai:branch-24.08from
jameslamb:suffix-split
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#31
Follow-up to #15245
RAPIDS DLFW builds prefer to build all RAPIDS packages together without CUDA suffixes, leading to the following set of requirements for
cudfwheels built there:cudf(notcudf-cu12)rmmnotrmm-cu12)cubinlinkerandptxcompileron CUDA 11,pynvjitlinkon CUDA 12)To meet all 3 of those, this proposes decomposing CUDA-suffixed dependencies in
dependencies.yamlinto two lists...cuda_suffixed="true"andcuda_suffixed="false".That'd allow DLFW builds to do the following to meet its requirements:
Checklist
Notes for Reviewers
Why still have the fallback matrices be CUDA 11 dependencies?
I'd originally included changese for rapidsai/build-planning#68 here, but chose to revert them to reduce the size of this diff and to make it absolutely clear... the fallback matrices' values are not relevant for devcontainers, DLFW, or normal wheel builds.