Skip to content

Support implicit array conversion with query-planning enabled#15378

Merged
rapids-bot[bot] merged 12 commits intorapidsai:branch-24.06from
rjzamora:implicit-array-conversion
Apr 5, 2024
Merged

Support implicit array conversion with query-planning enabled#15378
rapids-bot[bot] merged 12 commits intorapidsai:branch-24.06from
rjzamora:implicit-array-conversion

Conversation

@rjzamora
Copy link
Copy Markdown
Member

@rjzamora rjzamora commented Mar 22, 2024

Description

when query-planning is enabled, implicit conversion is not yet supported from a cudf-backed collection to a dask array. Some cuml + dask CI failures are related to this limitation. This PR adds basic support for implicit conversion.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress non-breaking Non-breaking change labels Mar 22, 2024
@rjzamora rjzamora self-assigned this Mar 22, 2024
@rjzamora rjzamora requested a review from a team as a code owner March 22, 2024 18:05
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 22, 2024
Copy link
Copy Markdown
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I suppose there's no need to push upstream because the intent is for this code (afaict from https://github.com/dask/dask-expr/blob/2f5f085511986e51d75caa499e3eab67a8c8b186/dask_expr/_backends.py#L80) to not be long-lived?

@rjzamora
Copy link
Copy Markdown
Member Author

Makes sense. I suppose there's no need to push upstream because the intent is for this code (afaict from https://github.com/dask/dask-expr/blob/2f5f085511986e51d75caa499e3eab67a8c8b186/dask_expr/_backends.py#L80) to not be long-lived?

Yeah, I'm hoping that the long-term fix for create_array_collection will be able to leverage the dispatch logic that is already upstream.

@rjzamora rjzamora added 3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress 3 - Ready for Review Ready for review by team labels Apr 4, 2024
@rjzamora
Copy link
Copy Markdown
Member Author

rjzamora commented Apr 5, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0ed224d into rapidsai:branch-24.06 Apr 5, 2024
@rjzamora rjzamora deleted the implicit-array-conversion branch April 5, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants