[REVIEW] Add GroupBy.dtypes#12783
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-23.04from Feb 16, 2023
Merged
Conversation
galipremsagar
added
bug
galipremsagar
commented
Feb 15, 2023
wence-
reviewed
Feb 15, 2023
| } | ||
| ) | ||
| df.index = index | ||
| return df |
Contributor
There was a problem hiding this comment.
This looks much more simple than the pandas implementation, but I guess it makes sense.
vyasr
approved these changes
Feb 15, 2023
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
One small suggestion to simplify, but otherwise LGTM.
shwina
reviewed
Feb 15, 2023
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
Co-authored-by: Ashwin Srinath <3190405+shwina@users.noreply.github.com>
shwina
approved these changes
Feb 15, 2023
galipremsagar
added
5 - Ready to Merge
bdice
reviewed
Feb 15, 2023
Contributor
Author
|
Currently blocked by an unrelated error: Discussing offline to resolve this. |
Contributor
|
In the interest of unblocking CI, I've made some small changes to patch this issue. I'll need to do a bit of a deeper investigation to figure out where cudf (or perhaps arrow) is leaking this dependency from; I'm not 100% convinced that it should be needed, but I could be mistaken (in which case my current patch won't need to be modified). |
Contributor
Author
|
CI passed, merging this PR now |
Contributor
Author
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
The changes to spdlog/fmt packaging in rmm caused an undefined symbol issue in cudf_kafka. To unblock CI in #12783, I simply added fmt to the list of required libraries for the Python package (see caf7adf and [the explanation](#12783 (comment))). The underlying issue turns out to be that by default usage of fmt results in the dependent assuming that the headers are compiled in not header-only mode. When using CMake to manage the build, fmt relies on use of the appropriate target `fmt::fmt-header-only` to configure the build such that anything using fmt knows to use it in header-only mode, which sets the `FMT_HEADER_ONLY` preprocessor macro under the hood. Since the Python cudf_kafka package is not built using CMake, however, this information was not propagated to its build from its dependencies (libcudf/libcudf_kafka). As a result, it was compiled expecting an external definition of some fmt symbols rather than inlining them. This PR removes the undesirable library dependency on fmt introduced in #12783 in favor of properly telling fmt to expect inlined symbols. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Bradley Dice (https://github.com/bdice) - Matthew Roeschke (https://github.com/mroeschke) URL: #12796
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
dtypesproperty toGroupBy, this will also fix some upstream dask breaking changes introduced in: dask/dask#9889Issue was discovered in: #12768 (comment)
Checklist