refactor CUDA versions in dependencies.yaml#671
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.02from Jan 11, 2024
jameslamb:rework-dependencies
Merged
refactor CUDA versions in dependencies.yaml#671rapids-bot[bot] merged 2 commits intorapidsai:branch-24.02from jameslamb:rework-dependencies
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.02from
jameslamb:rework-dependencies
Conversation
4 tasks
jakirkham
reviewed
Jan 11, 2024
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks James! 🙏
Had one question below
jakirkham
added
improvement
AyodeAwe
approved these changes
Jan 11, 2024
Member
|
/merge |
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
* switches to CUDA 12.2.2 for building conda packages and wheels
* adds new tests running against CUDA 12.2.2
* removes some unnecessary `cuda-version={major}.{minor}` stuff in `dependencies.yaml` that was missed in #671
### Notes for Reviewers
This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.
For more details see:
* rapidsai/build-planning#7
* rapidsai/shared-workflows#166
Planning a second round of PRs to revert these references back to a proper `branch-24.{nn}` release branch of `shared-workflows` once rapidsai/shared-workflows#166 is merged.
*(created with `rapids-reviser`)*
Authors:
- James Lamb (https://github.com/jameslamb)
- https://github.com/jakirkham
- Bradley Dice (https://github.com/bdice)
Approvers:
- Jake Awe (https://github.com/AyodeAwe)
- Bradley Dice (https://github.com/bdice)
- https://github.com/jakirkham
URL: #672
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#7.
Proposes splitting the
cuda-versiondependency independencies.yamlout to its own thing, separate from the bits of the CUDA Toolkit this project needs.Benefits of this change
cuda-versionversion in environments"12.*")condarecipe is missing a dependency" are caught in CI