Merge miniforge-cuda into ci-imgs#167
Conversation
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Hyunsu! 🙏
Had a few minor suggestions below
jameslamb
left a comment
There was a problem hiding this comment.
Thanks very much! Overall, this looks good to me I like the approach of sharing a single Dockerfile for ci-conda and miniforge-cuda.
Some things I checked, that are working well:
- the matrix in
matrix.yamlhere as of this PR exactly matches https://github.com/rapidsai/miniforge-cuda/blob/main/matrix.yaml - the
Dockerfilechanges here accurately capture the content of https://github.com/rapidsai/miniforge-cuda/blob/main/Dockerfile - the patterns for tags match what's been published at https://hub.docker.com/r/rapidsai/miniforge-cuda/tags (thanks especially for catching the
-base-forminiforge-cuda, I might have missed that)
However, I see 2 things that should be changed:
Ensure intermediate images are getting cleaned up in rapidsai/staging: on DockerHub
I think maybe something is broken with the jobs that delete temporary images?
I still see lots of *-167-* images at https://hub.docker.com/r/rapidsai/staging/tags?page=&page_size=&ordering=&name=-167-. That 167 corresponds to the PR number here on GitHub.
In theory, I think those should be getting removed by this:
Could you please look into that?
This PR does not finish the work
This PR shouldn't say it "closes" the work to move miniforge-cuda into this repo. Once this is merged and a few days have gone by with no issues, there are a few other things I think need to be done to consider this work complete. I just put those up in a task list at rapidsai/build-planning#48.
bdice
left a comment
There was a problem hiding this comment.
This looks fine to me, aside from @jameslamb's comments on intermediate image cleanup and follow-up tasks.
| # Define the values used for the "latest" tag | ||
| conda: | ||
| miniforge-cuda: | ||
| CUDA_VER: "12.2.2" |
There was a problem hiding this comment.
We need to update all these to 12.5. But that can be a follow-up PR.
#172 is handling this in the same way as rapidsai/docker#709. |
jameslamb
left a comment
There was a problem hiding this comment.
Changes in this PR look good and we should merge this. But please do see the other follow-up items I mentioned before we consider rapidsai/build-planning#48 complete.
Addresses rapidsai/build-planning#48