This repository was archived by the owner on Sep 2, 2024. It is now read-only.
fix agent crash when removing invalid image #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client attempts to "noramlize" image refs when deleting to allow for shortened image identifiers to be passed. When passing an invalid image ref this could result in the client requesting deletion of a nil image from the server. The server now silently succeed and do nothing while the client now checks for passing a nil image ref and lets the user know that no such image could be found. Fixes rancher#80 Signed-off-by: Jacob Blain Christen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client attempts to "noramlize" image refs when deleting to allow for
shortened image identifiers to be passed. When passing an invalid image
ref this could result in the client requesting deletion of a nil image
from the server. The server now silently succeed and do nothing while
the client now checks for passing a nil image ref and lets the user know
that no such image could be found.
Fixes #80
Signed-off-by: Jacob Blain Christen [email protected]