Allow to add any label to local cluster #4096
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most real use-case for that is to set a "real" cluster name via ClusterName label. So multiple Rancher/Fleet controller instances have unique name/label. Signed-off-by: Dinar Valeev <[email protected]>
Buzzglo
approved these changes
Sep 21, 2025
weyfonk
reviewed
Oct 31, 2025
Contributor
There was a problem hiding this comment.
LGTM apart from a small typo, thanks for your contribution!
(optional) Would you mind cherry-picking this commit which adds a couple of test cases?
| # The namespace where the fleet agent for the local cluster will be ran, if empty | ||
| # this will default to cattle-fleet-system | ||
| agentNamespace: "" | ||
| # Apply extra clusterLables to the local cluster bootstrapped by fleet-controller |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| # Apply extra clusterLables to the local cluster bootstrapped by fleet-controller | |
| # Apply extra clusterLabels to the local cluster bootstrapped by fleet-controller |
Member
|
Note that Rancher does not use Fleet's bootstrapping to create the local cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most real use-case for that is to set a "real" cluster name via ClusterName label. So multiple Rancher/Fleet controller instances have unique name/label.
Refers to #XXX
Additional Information
Checklist
fleet-docs repository.