Skip to content

Conversation

@davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Jun 11, 2024

This PR is just to use the fakemounter interface in some units tests where it was not initiated.

This prevent many dialogs asking for root password to appear when running tests in a desktop env do to the systemd integration of the default mounter.

Signed-off-by: David Cassany <[email protected]>
@davidcassany davidcassany requested a review from a team as a code owner June 11, 2024 11:29
cfg = config.NewRunConfig(
config.WithFs(fs),
config.WithRunner(runner),
config.WithMounter(mounter),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not defined any specific mounter by default uses the the real mounter

@davidcassany davidcassany marked this pull request as draft June 11, 2024 11:30
@davidcassany davidcassany marked this pull request as ready for review June 11, 2024 11:30
@davidcassany davidcassany added the kind/enhancement New feature or request label Jun 11, 2024
Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany merged commit 28c4e47 into rancher:main Jun 11, 2024
@davidcassany davidcassany deleted the extend_the_use_of_fake_mounter branch June 11, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants