Ensure subvolume snapshots is mounted to list snapshots #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <[email protected]>
kkaempf
reviewed
Jun 10, 2024
Contributor
kkaempf
left a comment
kkaempf
left a comment
There was a problem hiding this comment.
I see you provide a snapshotsMount implementation but where's the corresponding snapshotsUmount one ?
Contributor
Author
|
Yes, in fact there used to be only a snapshotsUmount one, but no snapshotsMount. It was this way because there was the assumption it was only mounted once and at the very same stage for all cases. This turns not to be accurate enough when upgrading the snapshot from the recovery system (likely to be a squashfs image on a different partition). |
davidcassany
commented
Jun 10, 2024
| bootloader types.Bootloader | ||
| installing bool | ||
| snapperArgs []string | ||
| snapshotsUmount func() error |
Contributor
Author
There was a problem hiding this comment.
Here is the umount function, which was already coded and used before this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixes an issue about how we were updating the
state.yamlfile after upgrades. For the corner case of running upgrades from the recovery system the<state_partition>/@/.snapshotsis unmounted before upgrading thestate.yamland this mount is required to properly list available snapshots and reflect that instate.yaml.