Fix stackable sources for build-iso #2061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frelon
reviewed
Apr 30, 2024
Contributor
|
We probably don't use the |
Contributor
Author
Well I discovered it trying to set the ssh authorized public key for a password less remote login into the ISO. So using |
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
fix_build_iso_overlay_flags
branch
2 times, most recently
from
36c5862 to
9d6da31
Compare
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
fix_build_iso_overlay_flags
branch
from
9d6da31 to
7503757
Compare
frelon
approved these changes
May 2, 2024
davidcassany
added a commit
to davidcassany/elemental-toolkit
that referenced
this pull request
Jul 18, 2024
* Fix stackable sources for build-iso * Move syncFunc as a parameter of DumpSource Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 22baf14)
davidcassany
added a commit
that referenced
this pull request
Jul 29, 2024
* Fix stackable sources for build-iso (#2061) * Fix stackable sources for build-iso * Move syncFunc as a parameter of DumpSource Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 22baf14) * Fix error return Signed-off-by: David Cassany <[email protected]> (cherry picked from commit f9934d7) * Change default root password Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 46a88e1) * Allow key pair of ssh connection in tests Signed-off-by: David Cassany <[email protected]> (cherry picked from commit a5f526d) * Set legacy password for upgrade test Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 6f0b28e) * Allow insecure registries (#2131) * Allow skipping TLS verification on registries Signed-off-by: David Cassany <[email protected]> * Improve error logging Signed-off-by: David Cassany <[email protected]> * Fix flag default value Signed-off-by: David Cassany <[email protected]> * Fix image extractor mock and use default TLS verification for tests Signed-off-by: David Cassany <[email protected]> --------- Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 22996ef) * Fix permissions * Set token to explicit content read permissions (cherry picked from commit 3d657c9) * Move permissions at top level (cherry picked from commit 8b8ae12) * Fix workflows, permissions at top level (cherry picked from commit d3da1cf) * Leftover from d3da1cf (cherry picked from commit 3206436) * Fix nested permissions definition Top level permissions can't be increased for specific jobs, hence setting the permission on each specific job on workflows that require more fine grain approach. In addition it removes the pull-request permission as this is mostly required for PR decorators, read/write labels, etc. (cherry picked from commit 1a0903a) * Refactor ci (#2137) * Refactor CI to use a local registry * Cache image and fetch image tarballs * Composite fetch images * Push to insecure registry with podman * Simplify workflow runs * Improve cache cleanup * Improve ip detection Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 644cdc7) * Fix cache cleaning for PRs and main pushes (#2144) * Fix cache cleaning for PRs and main pushes * Update .github/workflows/cache-cleanup.yaml Co-authored-by: Francesco Giudici <[email protected]> Signed-off-by: David Cassany Viladomat <[email protected]> (cherry picked from commit f54f683) * Remove unused steps in workflow Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 51a85a7) (cherry picked from commit 9f8d14fea58c2e458f8840d274422352f0b0b1c2) * Do not fetch upstream go dependencies Signed-off-by: David Cassany <[email protected]> * Update cmd/cloud-init.go Missing err Co-authored-by: Francesco Giudici <[email protected]> Signed-off-by: David Cassany Viladomat <[email protected]> --------- Signed-off-by: David Cassany <[email protected]> Signed-off-by: David Cassany Viladomat <[email protected]> Co-authored-by: Francesco Giudici <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the use of
--overlay-*flags in build-iso command. With the latest changes the were using the--deleteoption in rsync to dump the sources to be stacked on an already existing source. This PR distinguishes a couple of use cases the formerDumpSourcemethod equivalent is isMirrorRootnow, as this includes--deleteoption for rsync and the creation of essential root-tree mountpoint dirs such as/dev,/sys,/proc... I noted this as using theoverlay-isoflag in an ISO lead to an image including empty/dev,/tmp,/proc, etc.In addition this PR also removes the
DeployImagethat was not used anywhere in code, this was just a leftover.