Skip symlink if kernel already exists #2028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If kernel or initrd is named the default vmlinuz/initrd we skip the symlinking since the booting will work anyways. Signed-off-by: Fredrik Lönnegren <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
- Coverage 72.36% 72.34% -0.02%
==========================================
Files 76 76
Lines 9009 9012 +3
==========================================
+ Hits 6519 6520 +1
- Misses 1946 1947 +1
- Partials 544 545 +1 ☔ View full report in Codecov by Sentry. |
ldevulder
approved these changes
Mar 25, 2024
Contributor
ldevulder
left a comment
ldevulder
left a comment
There was a problem hiding this comment.
Just a small suggestion, but good to me!
| } { | ||
| // if kernel/initrd is actually named "vmlinuz"/"initrd" we just skip the symlink part. | ||
| if kernel == name || initrd == name { | ||
| continue |
Contributor
There was a problem hiding this comment.
It might be a good idea to add a Debugf call just to simplify the debugging in case of issue:
Suggested change
| continue | |
| cfg.Logger.Debugf("No symlink needed, keeping exising %s file", name) | |
| continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If kernel or initrd is named the default vmlinuz/initrd we skip the symlinking since the booting will work anyways.