Adding debug messages for snapper configuration #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
anmazzotti
approved these changes
Mar 6, 2024
Contributor
anmazzotti
left a comment
anmazzotti
left a comment
There was a problem hiding this comment.
Tested successfully, so looks good to me.
Signed-off-by: David Cassany <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
=======================================
Coverage 72.52% 72.53%
=======================================
Files 76 76
Lines 8906 8909 +3
=======================================
+ Hits 6459 6462 +3
Misses 1913 1913
Partials 534 534 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
With the current change it can't run the fallback test as the downloaded image does not include snapper. Which is good, it fails early in the process and it simply refuses to upgrade. Merging as the issue is in test-fallback itself, it should try to upgrade to the self image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.