Ensure /run/elemental/efi is RW for upgrades #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1976 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 74 74
Lines 8722 8722
=======================================
Hits 6365 6365
Misses 1838 1838
Partials 519 519 ☔ View full report in Codecov by Sentry. |
frelon
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 4cab6a0
In upgrade or reset hooks we can't assume
/run/elemental/efiis mounted as RW for thesuc-upgradescript, which recursively bind mounts/runand/devinto the container environment before callingelemental. The elemental binary detects the EFI partition at/host/run/elemental/efi, hence it remounts under/hostmountpoint not at/run/elemental/efi.IMHO the boot_assessment logic as a whole should be reviewed in the future, current approach is a bit convoluted and prone to fall into this sort of traps.