Use rancher/yip v1.4.8

[frelon]

This includes the update to vfs4.

Fixes #1911, #1913

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfcae7c) 73.85% compared to head (cfc1329) 73.83%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1916      +/-   ##
==========================================
- Coverage   73.85%   73.83%   -0.02%     
==========================================
  Files          71       71              
  Lines        7779     7759      -20     
==========================================
- Hits         5745     5729      -16     
+ Misses       1613     1611       -2     
+ Partials      421      419       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidcassany]

LGTM

[kkaempf]

This shouldn't have been merged.

It has a misleading title. 😞

[frelon]

This shouldn't have been merged.

It has a misleading title. 😞

I'm confused, what is misleading about the title?

[kkaempf]

This shouldn't have been merged.
It has a misleading title. 😞

I'm confused, what is misleading about the title?

The title just references one change ("Use rancher/yip v1.4.8") but the PR changes two things (update of yip, change to rancher/yip). This should've been two separate PRs imho.

[frelon]

This shouldn't have been merged.

It has a misleading title. 😞

I'm confused, what is misleading about the title?

The title just references one change ("Use rancher/yip v1.4.8") but the PR changes two things (update of yip, change to rancher/yip). This should've been two separate PRs imho.

Technically the title references both changes..

I agree it could have been two commits, but spending time splitting these relatively small bumps into several feels nitpicky to me (especially if the commits are later squashed...).