Add target for rpi disk #1859
Add target for rpi disk #1859
Conversation
frelon
force-pushed
the
build-disk-rpi
branch
2 times, most recently
from
5f557a8 to
9e1b93a
Compare
frelon
force-pushed
the
build-disk-rpi
branch
from
86a85d6 to
74e4a42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
+ Coverage 75.09% 75.10% +0.01%
==========================================
Files 67 67
Lines 6869 6872 +3
==========================================
+ Hits 5158 5161 +3
Misses 1340 1340
Partials 371 371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davidcassany
left a comment
davidcassany
left a comment
There was a problem hiding this comment.
I'd leave the build-hooks flag change out of this PR and eventually make a follow up PR to better manage and handle this use case including build, install, upgrade and reset commands or any command that makes use of the hooks concept.
cmd/build-disk.go
Outdated
| c.Flags().VarP(imgType, "type", "t", "Type of image to create") | ||
| c.Flags().StringSliceP("cloud-init", "c", []string{}, "Cloud-init config files") | ||
| c.Flags().StringSliceP("cloud-init", "c", []string{}, "Cloud-init config files to include in disk") | ||
| c.Flags().StringSlice("build-hooks", []string{}, "Paths to cloud-init config files to run during build") |
There was a problem hiding this comment.
This rename is not enough, it should be adapted within the pkg/types/v1/config.go at DiskSpec definition too.
Note for later. I am also wondering if shouldn't we make this change consistent to all commands and then have install-hooks, upgrade-hooks, reset-hooks flags.
There was a problem hiding this comment.
Yep, I brought back the cloud-init-paths for now since it is needed for this PR to produce a bootable rpi disk.
I also think we should rework the hooks in a follow up PR 👍
frelon
force-pushed
the
build-disk-rpi
branch
from
d2360a1 to
1ba600d
Compare
This commit adds a flavor for tumbleweed raspberry pi image that uses a after-disk hook to copy firmware into the EFI partition. Signed-off-by: Fredrik Lönnegren <[email protected]>
Signed-off-by: Fredrik Lönnegren <[email protected]>
frelon
force-pushed
the
build-disk-rpi
branch
from
1ba600d to
7e7703c
Compare
Signed-off-by: Fredrik Lönnegren <[email protected]>
4 participants
This commit adds a flavor for tumbleweed raspberry pi image that uses a after-disk hook to copy firmware into the EFI partition.