Skip to content

Conversation

@davidcassany
Copy link
Contributor

This commit adds an installer test and moves the smoke test to be executed on the installed system rather than the disk build.

@davidcassany davidcassany requested a review from a team as a code owner October 27, 2023 12:46
@davidcassany davidcassany marked this pull request as draft October 27, 2023 12:52
This commit adds an installer test and moves the smoke
test to be executed on the installed system rather than the
disk build.

Signed-off-by: David Cassany <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.34%. Comparing base (9c55b9d) to head (4025000).
Report is 351 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1851   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files          67       67           
  Lines        6818     6818           
=======================================
  Hits         5137     5137           
  Misses       1311     1311           
  Partials      370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidcassany davidcassany marked this pull request as ready for review October 27, 2023 22:44
Signed-off-by: David Cassany <[email protected]>
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidcassany davidcassany merged commit bf2cdb9 into rancher:main Oct 30, 2023
@davidcassany davidcassany deleted the add_installer_test branch October 30, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants