Skip to content

Conversation

@brandond
Copy link
Member

@brandond brandond commented Aug 15, 2023

We had similar code to prevent blocking when calling Update(), but not in the init function.

func (s *storage) Update(secret *v1.Secret) error {
// Asynchronously update the Kubernetes secret, as doing so inline may block the listener from
// accepting new connections if the apiserver becomes unavailable after the Secrets controller
// has been initialized. We're not passing around any contexts here, nor does the controller
// accept any, so there's no good way to soft-fail with a reasonable timeout.

Ref: rancher/rancher#42278

@brandond brandond force-pushed the fix-create-deadlock branch from 5fb2b91 to 8cc3fe9 Compare August 15, 2023 00:33
We had similar code to prevent blocking when calling Update(), but not in the init function.

Ref: rancher/rancher#42278
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond force-pushed the fix-create-deadlock branch from 8cc3fe9 to 3b8aa34 Compare August 15, 2023 00:40
@brandond brandond merged commit 1c60bf4 into rancher:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants