Don't merge expired certs over the top of an unexpired cert #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niusmallnan
reviewed
Jul 20, 2022
Fixes an issue where an expired Kubernetes secret would replace the renewed locally-cached cert after cluster startup. Signed-off-by: Brad Davidson <[email protected]>
Most of our products actually renew at 90 days, so make that the default. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix_merge_expired
branch
from
4f973e1 to
29bbb2f
Compare
briandowns
approved these changes
Jul 21, 2022
dereknola
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where an expired Kubernetes secret would replace the renewed locally-cached cert after cluster startup.
Related to k3s-io/k3s#5163
Signed-off-by: Brad Davidson [email protected]