Fix ListenAndServe certificate expiration by preloading certs #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
expire_debug
branch
2 times, most recently
from
6c57f83 to
ba42cc3
Compare
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
expire_debug
branch
from
ba42cc3 to
91ca9c0
Compare
Signed-off-by: Brad Davidson <[email protected]>
1 task
nickgerace
approved these changes
Nov 24, 2021
| } | ||
|
|
||
| if !factory.IsStatic(secret) && !factory.NeedsUpdate(l.maxSANs, secret, cn...) { | ||
| if factory.IsStatic(secret) || !factory.NeedsUpdate(l.maxSANs, secret, cn...) { |
Comment on lines
+421
to
+423
| if err := l.updateCert(h); err != nil { | ||
| logrus.Errorf("failed to update cert with HTTP request Host header: %v", err) | ||
| } |
Comment on lines
+104
to
+106
| if err != nil && !errors.IsAlreadyExists(err) { | ||
| logrus.Warnf("Failed to create Kubernetes secret: %v", err) | ||
| } |
Contributor
There was a problem hiding this comment.
Should we add retry logic here or will the warning log suffice? I'm led the believe that a non-"IsNotFound" error will likely reappear upon retry, so I'm good with this "as-is", but thought I'd ask if you considered it.
Member
Author
There was a problem hiding this comment.
The Kubernetes Secret also gets watched in the background, and the sync from the watch plus the write-back of any local updates to the secret will ensure that it is eventually consistent.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with how
server.ListenAndServeloads certificates. It sets up a memory -> kubernetes -> memory Secret storage stack, which combined with lazy (on-demand) loading of certificate data, caused the certificate to not be properly renewed when it expired.It also resolves a regression from #38 - while IPv6 addresses are no longer rejected by the CN regex, they cannot actually be stored in the CN annotation, as semicolons are not allowed in annotation keys. This also fixes handling of hostnames that are more than 41 characters long.