Allow for default expiration days to be loaded from env #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I cannot assign reviewers, so for visibility: this PR is awaiting review from @thedadams |
thedadams
suggested changes
Nov 18, 2021
thedadams
approved these changes
Nov 18, 2021
kinarashah
reviewed
Nov 19, 2021
kinarashah
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the consumer of dynamiclistener's cert generation to specify the number of days until expiration via ENV VAR. By default, not supplying the ENV VAR will result in the same behavior as before. The ENV VAR is optional and specifying will override the default. If any issues occur, we will fallback to the default value.
Partially resolves: rancher/rancher#35366