Fix panic on nil secret #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use configured secret namespace/name in error message, to avoid panicing if the secret is invalid because it is nil Signed-off-by: Brad Davidson <[email protected]>
tomleb
approved these changes
Sep 12, 2025
brandond
added a commit
to brandond/dynamiclistener
that referenced
this pull request
Oct 9, 2025
Use configured secret namespace/name in error message, to avoid panicing if the secret is invalid because it is nil Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit d9174a1) Signed-off-by: Brad Davidson <[email protected]>
brandond
added a commit
that referenced
this pull request
Oct 10, 2025
* Sync changes to Kubernetes secret through workqueue instead of goroutines with locks (#202) Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit b12f85e) Signed-off-by: Brad Davidson <[email protected]> * fix dynamic-cert.json permission (#196) (cherry picked from commit 2fb4ae1) Signed-off-by: Brad Davidson <[email protected]> * Fix panic on nil secret (#204) Use configured secret namespace/name in error message, to avoid panicing if the secret is invalid because it is nil Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit d9174a1) Signed-off-by: Brad Davidson <[email protected]> * Do not update memory storage with a nil secret (#205) Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit 7ad4185) Signed-off-by: Brad Davidson <[email protected]> * Avoid creating certs that violate Apple requirements for macOS 10.15 (#208) * Prevent creating non-standards compliant certs. Changes generated certificates to have a NotBefore based on either the CA NotBefore or the current time. This prevents creation of certificates that are valid for too long making them return errors on platforms like MacOS. * Add license header and add test cases (cherry picked from commit 3e35acf) Signed-off-by: Brad Davidson <[email protected]> --------- Signed-off-by: Brad Davidson <[email protected]> Co-authored-by: Siva Kanakala <[email protected]> Co-authored-by: Wesley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use configured secret namespace/name in error message, to avoid panicing if the secret is invalid because it is nil