Update pinned dev requirements + fix KeyError if license matches multiple specified licenses#217
Closed
cdce8p wants to merge 6 commits into
Closed
Update pinned dev requirements + fix KeyError if license matches multiple specified licenses#217cdce8p wants to merge 6 commits into
cdce8p wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-5.5.0 #217 +/- ##
==========================================
Coverage 99.56% 99.56%
==========================================
Files 1 1
Lines 456 457 +1
==========================================
+ Hits 454 455 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reactive-firewall
self-requested a review
October 9, 2025 04:21
reactive-firewall
added
the
dependencies
cdce8p
changed the title
cdce8p
commented
Oct 10, 2025
Contributor
Author
|
Changed the target branch to |
reactive-firewall
added a commit
that referenced
this pull request
Oct 13, 2025
…into patch-partial-matching-refactor-231 * includes and supersedes #216 * includes and supersedes #217 * includes and supersedes #224 * supersedes #234 * patch-2: Replaced element check logic with built in set.discard method Fixed: KeyError caused due to the same element getting removed from a set twice * fix-keyerror: Fix KeyError on double deletion * update-requirements: Update pinned requirements again Add changelog entry Fix KeyError if license matches multiple allow-only licenses Fix test case Update pinned dev requirements * Closes GHI #231 (and related issues with modifing sets within loops) * Improved related testing slightly with extra test-cases Resolves Conflicts in: piplicenses.py Co-authored-by: Marc Mueller <cdce8p@users.noreply.github.com> Co-authored-by: Anmol Deep <anmol-aidora@users.noreply.github.com> Co-authored-by: Florian Wünsche <flontis@users.noreply.github.com>
1 task
Collaborator
|
Closing as Included-in and Superseded-by PR #238 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.