Fix #1386 by removing dependency of Devise for logout_path and logout_method. #2062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f Devise is no present (need a Config for this).
sferik
added a commit
that referenced
this pull request
Sep 7, 2014
Fix #1386 by removing dependency of Devise for logout_path and logout_method.
Collaborator
|
Nice. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the main app can define a logout path on its routes and it will just work.
Also, logout_method is now an application helper and have a fallback to a
default value of :delete. It will just work (showing a logout link and all)
if you just add a route like the following:
delete 'sign_out', :to => 'sessions#destroy', as: 'logout'