Add new scrubber suitable for strip tags but adding whitespace#183
Open
jhottenstein wants to merge 2 commits intorails:mainfrom
Open
Add new scrubber suitable for strip tags but adding whitespace#183jhottenstein wants to merge 2 commits intorails:mainfrom
jhottenstein wants to merge 2 commits intorails:mainfrom
Conversation
flavorjones
force-pushed
the
jess/space-block-scrubber
branch
from
f8f50fc to
bd5ea3a
Compare
Member
|
I rebased and applied rubocop autocorrects. I'll look into why this acts differently between Nokogiri's JRuby and CRuby implementations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step forward to address #154 (and rails/rails#8331)
Will be accompanied by a PR to Rails to use this new scrubber