Does not work in environments where :en is not allowed as a locale

[wout]

Our app only supports :fr and :nl, and enforces those two locales. Mission control will crash in that case:

 I18n::InvalidLocale: :en is not a valid locale raise I18n::InvalidLocale.new(locale) if !locale_available?(locale) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    def enforce_available_locales!(locale)
      if locale != false && config.enforce_available_locales
        raise I18n::InvalidLocale.new(locale) if !locale_available?(locale)
      end
    end

I've now worked around it by adding :en and creating a fallback to :nl:

    config.i18n.available_locales = %i[nl fr en]
    config.i18n.fallbacks[:en] = :nl

[rosa]

@wout, what version of Mission Control are you running?

[wout]

In my Gemfile:

gem 'mission_control-jobs', '~> 1.0'

In the lockfile:

mission_control-jobs (1.0.1)

Update:
Using it in Rails 8.0.1

[rosa]

Could you provide a minimal reproduction for this so I can troubleshoot it?

[wout]

Sure. Adding the following config to config/application.rb should do the trick:

module AppName
  class Application < Rails::Application
    # ...
    config.i18n.default_locale = :nl
    config.i18n.available_locales = %i[nl fr]
    config.i18n.enforce_available_locales = true
    # ...
  end
end

Or are you looking for something more elaborate?

[rosa]

@wout yes. With that alone, I can't reproduce it. Mission Control has its own I18n configuration to not interfere with the app's, which is supposed to handle this scenario (:en not being available in the host app as locale). Thus, I can't reproduce this with a simple app where I set this

    config.i18n.default_locale = :nl
    config.i18n.available_locales = %i[nl fr]
    config.i18n.enforce_available_locales = true

I'm guessing there's something else going on in your case that makes this not to work 🤔

[wout]

Okay, let me see if I can create a new app to reproduce the issue. This particular app initially started on Rails 2, so there may be some legacy configuration somewhere making the difference.

Just to be clear, the app starts up and runs fine. It's only when visiting the mounted route that the error occurs (mount MissionControl::Jobs::Engine, at: '/background_jobs').

[rosa]

Just to be clear, the app starts up and runs fine. It's only when visiting the mounted route that the error occurs (mount MissionControl::Jobs::Engine, at: '/background_jobs').

Yeah, this is what I'm not seeing with a simple test app 😕 Mission Control works fine. There's also a test that tries to simulate this scenario, setting only es and nl as available locales.

[wout]

I've now copied over all concerns and configurations that are related to i18n from our app to the test app and I still can't reproduce it. So maybe it's caused by a dependency? I'm not sure.

Anyway, I'm going to close this for now as this is probably an edge case. When I find the root of this I'll report back. Thanks for your time!

[rosa]

Sounds good, thank you! 🙌

[chloerei]

ca09138 is not in v1.0.1, maybe release a new version?

[rosa]

@chloerei yeah, I was planning to do that today. That fix wouldn't have changed the outcome here, though, it was for a different bug, where Mission Control would work fine but cause an issue in the host app if loaded before.