Skip to content

GlobalID::Identification clears memoized to_global_id on dup #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaelfranca merged 2 commits into from
Aug 24, 2018
Merged

GlobalID::Identification clears memoized to_global_id on dup #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9f78c0
GlobalID::Identification clears memoized to_global_id on dup
bradleybuda Aug 22, 2018
8b3af4c
Remove memoization of GlobalID::Identification#to_global_id
bradleybuda Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/global_id/identification.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module Identification
extend ActiveSupport::Concern

def to_global_id(options = {})
@global_id ||= GlobalID.create(self, options)
GlobalID.create(self, options)
end
alias to_gid to_global_id

Expand Down
8 changes: 8 additions & 0 deletions test/cases/global_identification_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,12 @@ class GlobalIdentificationTest < ActiveSupport::TestCase
assert_equal SignedGlobalID.create(@model, some: 'param'), @model.to_signed_global_id(some: 'param')
assert_equal SignedGlobalID.create(@model, some: 'param'), @model.to_sgid(some: 'param')
end

test 'dup should clear memoized to_global_id' do
global_id = @model.to_global_id
dup_model = @model.dup
dup_model.id = @model.id + 1
dup_global_id = dup_model.to_global_id
assert_not_equal global_id, dup_global_id
end
end