Breaking: add combine method for groupby output, fixing similar for AbstractDimStack
#903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
reviewed
Jan 14, 2025
| If `dims` is given, combine only the dimensions in `dims`. The reducing function | ||
| `f` must accept a `dims` keyword. | ||
| """ | ||
| function combine(f::Function, gb::DimGroupByArray{G}; dims=:) where G |
Collaborator
There was a problem hiding this comment.
DataAPI.combine? Since DD owns one of the types...
Owner
Author
There was a problem hiding this comment.
It doesn't exist yet JuliaData/DataAPI.jl#65 ;)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## breaking #903 +/- ##
=========================================
Coverage 80.60% 80.61%
=========================================
Files 54 54
Lines 5130 5168 +38
=========================================
+ Hits 4135 4166 +31
- Misses 995 1002 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Did this close #745? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
combinemethod to make things like this easier:combine(f, groupby(dim_array_or_stack, Ti=month); dims=Ti)It helps with recomposing grouped output into a single DimArray/DimStack allowing for partial reductions of the grouped content.
Surprisingly hardly any code needed to do this, once I actually fixed
similarto make more sense on DimStack, and a few bugs insetindex!on stacks. I guess in the past it wasn't totally clear how these things should work. But makingcombinejust work like this for arrays or stacks probably means the design is correct now.similarnow matchesNamedTupleeltypes as layer types, and keeps the same dimension structure as the original stack (layers missing dimensions are still missing dimensions aftersimilar).