Skip to content

forward rebuildsliced dispatch instead of duplicating code#1141

Merged
rafaqz merged 2 commits into
rafaqz:mainfrom
tiemvanderdeure:rebuildsliced_tuple
Nov 20, 2025
Merged

forward rebuildsliced dispatch instead of duplicating code#1141
rafaqz merged 2 commits into
rafaqz:mainfrom
tiemvanderdeure:rebuildsliced_tuple

Conversation

@tiemvanderdeure

Copy link
Copy Markdown
Collaborator

Just a tiny improvement so it is easier to implement a custom rebuildsliced for your own AbstractDimStack type.

@tiemvanderdeure

Copy link
Copy Markdown
Collaborator Author

Been a while since I used python much, what is going on here??

    CondaPkg Creating environment
             │ C:\Users\runneradmin\.julia\artifacts\e2186c495339478b9d2992fa21edd824592d4de0\bin\micromamba.exe
             │ -r C:\Users\runneradmin\.julia\scratchspaces\0b3b1443-0f03-428d-bdfb-f27f9c1191ea\root
             │ create
             │ -y
             │ -p C:\Users\runneradmin\.julia\conda_environments\dimensionaldata-tests
             │ --override-channels
             │ numpy[version='*']
             │ openssl[version='>=3, <3.6, >=3, <3.6']
             │ python[version='3.13.*, >=3.10,<3.14',channel='conda-forge',build='*cp*']
             │ xarray[version='*']
             └ -c conda-forge
critical libmamba Multiple errors occured:
    Download error (35) SSL connect error [https://conda.anaconda.org/conda-forge/noarch/repodata.json.zst]
    schannel: next InitializeSecurityContext failed: CRYPT_E_REVOCATION_OFFLINE (0x80092013) - The revocation function was unable to check revocation because the revocation server was offline.
    Subdir conda-forge/noarch not loaded!

@rafaqz

rafaqz commented Nov 18, 2025

Copy link
Copy Markdown
Owner

Maybe we need to update deps?

@JamesWrigley

@JamesWrigley

Copy link
Copy Markdown
Contributor

Cloudflare maybe? 🐙 Could you try re-running the tests now?

@rafaqz rafaqz closed this Nov 19, 2025
@rafaqz rafaqz reopened this Nov 19, 2025
@codecov

codecov Bot commented Nov 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.96%. Comparing base (e71bcbb) to head (f3ffbf1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/stack/stack.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
+ Coverage   86.91%   86.96%   +0.04%     
==========================================
  Files          55       55              
  Lines        5341     5338       -3     
==========================================
  Hits         4642     4642              
+ Misses        699      696       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixcremer

Copy link
Copy Markdown
Collaborator

The nightly failure is bramtayl/Unzip.jl#12

@tiemvanderdeure

Copy link
Copy Markdown
Collaborator Author

And the documentation now fails on something else:

I think something changed in documenter so it is now stricter about double naming, like a function with a docstring and a sectino of the docs with the same name.

CrossReferences: building cross-references.
Error: Cannot resolve @ref for md"[`Lookups`](@ref)" in docs/src/dimensions.md.
- Header with slug 'Lookups' is not unique in docs/src/dimensions.md.
Error: Cannot resolve @ref for md"[`rebuild`](@ref)" in docs/src/api/reference.md.
- Header with slug 'rebuild' is not unique in docs/src/api/reference.md.
Error: Cannot resolve @ref for md"[`rebuild`](@ref)" in docs/src/api/reference.md.
- Header with slug 'rebuild' is not unique in docs/src/api/reference.md.
Error: Cannot resolve @ref for md"[`rebuild`](@ref)" in docs/src/api/reference.md.
- Header with slug 'rebuild' is not unique in docs/src/api/reference.md.
Error: Cannot resolve @ref for md"[`rebuild`](@ref)" in docs/src/object_modification.md.
- Header with slug 'rebuild' is not unique in docs/src/object_modification.md.
CheckDocument: running document checks.
Populate: populating indices.

@rafaqz

rafaqz commented Nov 20, 2025

Copy link
Copy Markdown
Owner

Oh I think how documenter slugs works has changed

@lazarusA

Copy link
Copy Markdown
Collaborator

Oh I think how documenter slugs works has changed

I fixed that in #1143

@rafaqz rafaqz merged commit 2043ccc into rafaqz:main Nov 20, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants