Skip to content

Conversation

@m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jun 15, 2020

Related Issue(s): #835

Proposed Changes:

  1. Add unique/resolvable JSON Schema ids
  2. Allow schema urls in stac_extenions
  3. Remove validation instructions
  4. Adapt CI to host JSON Schemas

Open questions:

  1. Schemas for the dev branch only work when we replace all version numbers in the schemas with dev and then on each release replace dev with the version number again. Is that worth the hassle? Yes, we do replace dev with the version number, added to process.md
  2. Is it confusing that I removed json-schema from the paths? Feels a bit cleaner. added json-schema back to the path
  3. Due to 2, the $refs are now all absolute instead of relative. Is that okay? relative again
  4. It seems I couldn't make the deploy key working properly. Can anyone assist? It works locally with username and password... Solved
  5. Why is the CI job running for PRs? Solved

ToDo for @cholmes: Setup schemas.stacspec.org and add the CNAME file to the repo.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr linked an issue Jun 15, 2020 that may be closed by this pull request
@m-mohr m-mohr added this to the 1.0.0-beta.2 milestone Jun 15, 2020
@m-mohr m-mohr requested review from jbants and lossyrob June 16, 2020 16:15
Copy link
Contributor

@jbants jbants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the extensions $id's all called schema.json?
Does it make sense to name them after the extension?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jun 16, 2020

It's the file name. I don't think that's an issue as the other parts of the URL (extension folder) will make the $id unique, e.g. https://stacspec.org/schemas/v1.0.0-beta.1/extensions/label/schema.json#

@m-mohr m-mohr changed the title Unique schema $id's (host schemas on stacspec) JSON Schemas, Validation and CI Jun 17, 2020
@m-mohr m-mohr marked this pull request as ready for review June 17, 2020 12:25
@cholmes
Copy link
Contributor

cholmes commented Jun 19, 2020

http://schemas.stacspec.org is set up and looks to be working.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jun 19, 2020

Great, thanks. Now we need to discuss the open questions (see first post)

@m-mohr m-mohr force-pushed the schema-ids branch 2 times, most recently from 673de85 to 874ec16 Compare June 24, 2020 16:20
@m-mohr
Copy link
Collaborator Author

m-mohr commented Jun 24, 2020

Updated PR, two CI issues to be fixed, but need help with them.

@m-mohr m-mohr marked this pull request as draft June 25, 2020 15:40
@m-mohr
Copy link
Collaborator Author

m-mohr commented Jun 25, 2020

So, it should work now. Still need to check again whether I can make my node validator work with the new schemas, but other than that, this PR is finished.

@m-mohr m-mohr marked this pull request as ready for review July 1, 2020 17:17
@m-mohr
Copy link
Collaborator Author

m-mohr commented Jul 8, 2020

The validator works as expected, everything seems to be valid. Only need another approval for the PR.

@cholmes cholmes merged commit 7289532 into dev Jul 8, 2020
@m-mohr m-mohr deleted the schema-ids branch July 8, 2020 15:14
@m-mohr m-mohr mentioned this pull request Jul 8, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unique schema $id's (host schemas on stacspec)

4 participants