-
Notifications
You must be signed in to change notification settings - Fork 188
JSON Schemas, Validation and CI #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jbants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the extensions $id's all called schema.json?
Does it make sense to name them after the extension?
|
It's the file name. I don't think that's an issue as the other parts of the URL (extension folder) will make the $id unique, e.g. |
|
http://schemas.stacspec.org is set up and looks to be working. |
|
Great, thanks. Now we need to discuss the open questions (see first post) |
673de85 to
874ec16
Compare
|
Updated PR, two CI issues to be fixed, but need help with them. |
|
So, it should work now. Still need to check again whether I can make my node validator work with the new schemas, but other than that, this PR is finished. |
|
The validator works as expected, everything seems to be valid. Only need another approval for the PR. |
Related Issue(s): #835
Proposed Changes:
Open questions:
Schemas for the dev branch only work when we replace all version numbers in the schemas with dev and then on each release replace dev with the version number again. Is that worth the hassle?Yes, we do replace dev with the version number, added to process.mdIs it confusing that I removed json-schema from the paths? Feels a bit cleaner.added json-schema back to the pathDue to 2, the $refs are now all absolute instead of relative. Is that okay?relative againIt seems I couldn't make the deploy key working properly. Can anyone assist? It works locally with username and password...SolvedWhy is the CI job running for PRs?SolvedToDo for @cholmes: Setup schemas.stacspec.org and add the CNAME file to the repo.PR Checklist: