Skip to content

Requester Pays Best Practice #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 2, 2021
Merged

Requester Pays Best Practice #1021

merged 14 commits into from
Mar 2, 2021

Conversation

@cholmes
Copy link
Contributor

@cholmes cholmes commented Mar 2, 2021

Related Issue(s): #896

Proposed Changes:

  1. Added best practice section with recommendations to put STAC json in public bucket even if data is in requester pays
  2. recommendation to use cloud-specific request protocols
  3. NOTE - did not yet add a link to the storage extension, since it's just a PR, and one that will get closed. Can add the recommendation in when we get a location for it.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG.

philvarner
philvarner reviewed Mar 2, 2021
View reviewed changes
philvarner
philvarner reviewed Mar 2, 2021
View reviewed changes
philvarner
philvarner reviewed Mar 2, 2021
View reviewed changes
@cholmes
Update best-practices.md
990df62 
Co-authored-by: Phil Varner <[email protected]>
philvarner
philvarner reviewed Mar 2, 2021
View reviewed changes
philvarner
philvarner reviewed Mar 2, 2021
View reviewed changes
philvarner
philvarner reviewed Mar 2, 2021
View reviewed changes
cholmes and others added 3 commits March 2, 2021 07:05
@cholmes
Update best-practices.md
5684a3b 
Co-authored-by: Phil Varner <[email protected]>
@cholmes
Update best-practices.md
fff73c7 
Co-authored-by: Phil Varner <[email protected]>
@cholmes
Update best-practices.md
435a738 
Co-authored-by: Phil Varner <[email protected]>
philvarner
philvarner reviewed Mar 2, 2021
View reviewed changes
@cholmes
Update best-practices.md
8671f5a 
Co-authored-by: Phil Varner <[email protected]>
philvarner
philvarner reviewed Mar 2, 2021
View reviewed changes
lossyrob
lossyrob approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@lossyrob lossyrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, reworded and fixed some typos.

cholmes and others added 4 commits March 2, 2021 08:46
@cholmes @lossyrob
Update best-practices.md
8f6f0e4 
Co-authored-by: Rob Emanuele <[email protected]>
@cholmes @lossyrob
Update best-practices.md
f184443 
Co-authored-by: Rob Emanuele <[email protected]>
@cholmes @lossyrob
Update best-practices.md
11c2341 
Co-authored-by: Rob Emanuele <[email protected]>
@cholmes @lossyrob
Update best-practices.md
a606406 
Co-authored-by: Rob Emanuele <[email protected]>
@cholmes cholmes merged commit e5ed34f into dev Mar 2, 2021
@cholmes cholmes deleted the req-pays-practice branch March 2, 2021 16:49
@schwehr schwehr mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philvarner philvarner philvarner left review comments

@matthewhanson matthewhanson matthewhanson approved these changes

+1 more reviewer

@lossyrob lossyrob lossyrob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cholmes @philvarner @matthewhanson @lossyrob