Closes#1849: include a message id tag in rabbitmqactivitysource for published messages #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
Contributor
Author
|
@lukebakken : Here's the PR. I'm not sure how to assign Reviewers. I don't seem to have permission to do so, nor would I know who best to conduct the review and merge. Can you assist? Thanks! |
Collaborator
Collaborator
|
Currently on longer vacation. Happy to review when back but it will take a whileAm 14.07.2025 18:50 schrieb Luke Bakken ***@***.***>:lukebakken left a comment (rabbitmq/rabbitmq-dotnet-client#1852)
I'm hoping @stebet, @lmolkova and others more familiar with OTel can review this.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Contributor
Author
lukebakken
force-pushed
the
1849-include-messageid-tag-in-rabbitmqactivitysource-during-basicpublish
branch
from
c2d7511 to
96b07b8
Compare
lukebakken
previously approved these changes
Aug 19, 2025
…ageid tag to be included in trace span updated tests for messageid tag corrected broken tests after bad conflict resolution from merging main into feature branch
lukebakken
force-pushed
the
1849-include-messageid-tag-in-rabbitmqactivitysource-during-basicpublish
branch
from
96b07b8 to
c1c54f1
Compare
lukebakken
approved these changes
Aug 19, 2025
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Addresses #1849.
Updated the
RabbitMQActivitySource.BasicPublishmethod to allow forIReadOnlyBasicPropertiesto be passed in as an additional parameter. This allows theIReadOnlyBasicPropertiesto then be passed along to thePopulateMessagingTagsmethod, which adds theMessageIdas a tag.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
CONTRIBUTING.mddocument