Skip to content

Conversation

@meum
Copy link
Contributor

@meum meum commented Jan 28, 2025

Proposed Changes

Adds an option to set remote span as parent rather than link when propagating Opentelemetry context between the publisher and receiver.
See issue #1666

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

@lukebakken lukebakken self-assigned this Jan 28, 2025
@lukebakken lukebakken added this to the 7.2.0 milestone Jan 28, 2025
Copy link

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from otel semconv perspective!

@meum
Copy link
Contributor Author

meum commented Jan 31, 2025

Does it make more sense to remove the TracingLinkType enum, and just have a bool UsePublisherAsParent?
My original reason for making an enum was that we might want something more advanced in the future, e.g. making it configurable per message, or automatically determining if parent/child makes sense based on the exchange type. But I'm not sure what that would look like.

@stebet
Copy link
Contributor

stebet commented Jan 31, 2025

LGTM :)

Update more tests

Change to always link, optionally parent/child

Don't create list unless needed

Co-authored-by: Liudmila Molkova <[email protected]>

Change default to AlwaysParentChildAndLink

Remove TracingLinkType enum, use bool UsePublisherAsParent instead
@lukebakken lukebakken force-pushed the opentelemetry-parent-child-linking branch from 50f0c5f to 89cdb52 Compare May 12, 2025 16:03
@meum
Copy link
Contributor Author

meum commented Jul 11, 2025

Any ETA on when this will be merged/released?

Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going on what other people said about this PR 😇

@lukebakken lukebakken merged commit 35317bb into rabbitmq:main Jul 11, 2025
10 checks passed
@lukebakken
Copy link
Collaborator

@meum - I'm waiting to hear back on this issue to release 7.2.0.

If I don't hear back within two weeks, I will finish up what I can for that issue, and will get 7.2.0 out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants