Skip to content

Refactor the API interfaces#21

Merged
Gsantomaggio merged 12 commits into
mainfrom
targets_publisher
Jan 30, 2025
Merged

Refactor the API interfaces#21
Gsantomaggio merged 12 commits into
mainfrom
targets_publisher

Conversation

@Gsantomaggio

@Gsantomaggio Gsantomaggio commented Jan 27, 2025

Copy link
Copy Markdown
Member
  • ExchangeAddress and QueueAddress replace the string to the address
  • Add types definition for the Queue and Exchange declaration:
DeclareQueue(context.TODO(), &rabbitmq_amqp.QuorumQueueSpecification{
		Name: queueName,
	
	})
DeclareQueue(context.TODO(), &rabbitmq_amqp.ClassicQueueSpecification{
		Name: queueName,
	
	})

TargetPublisher

publisher, err := amqpConnection.NewTargetPublisher(context.Background(), .... , "getting-started-publisher")

target

Multi Targets Publisher

mtPublisher, err := connection.NewMultiTargetsPublisher(context.Background(), "test")

multi targets

- Add connection.NewTargetsPublisher API to create a publisher able to
  send a message to different targets

- Rename Publisher to TargetPublisher
- Rename connection.Publisher to connection.NewTargetPublisher

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio added this to the 0.1.0-alpha.2 milestone Jan 27, 2025
@Gsantomaggio
Gsantomaggio marked this pull request as ready for review January 27, 2025 13:39
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@lukebakken

Copy link
Copy Markdown
Contributor

I will review this today!

@lukebakken lukebakken self-assigned this Jan 27, 2025
that will avoid problems during the address build.

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio changed the title Add targets publisher Refactor the API interfaces Jan 30, 2025
@Gsantomaggio
Gsantomaggio merged commit 89c4dd7 into main Jan 30, 2025
@Gsantomaggio
Gsantomaggio deleted the targets_publisher branch January 30, 2025 10:29

@lukebakken lukebakken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants