Skip to content

khepri_tx_adv: Allow logger macros in transactions#377

Merged
dumbbell merged 1 commit into
v0.17.xfrom
allow-logger-macros-in-transactions
Mar 19, 2026
Merged

khepri_tx_adv: Allow logger macros in transactions#377
dumbbell merged 1 commit into
v0.17.xfrom
allow-logger-macros-in-transactions

Conversation

@dumbbell
Copy link
Copy Markdown
Collaborator

Why

We already allow calls such as logger:alert(). It makes sense to allow the functions used by the corresponding ?LOG_*() macros.

[Why]
We already allow calls such as `logger:alert()`. It makes sense to allow
the functions used by the corresponding `?LOG_*()` macros.
@dumbbell dumbbell added this to the v0.17.6 milestone Mar 19, 2026
@dumbbell dumbbell self-assigned this Mar 19, 2026
@dumbbell dumbbell added the bug Something isn't working label Mar 19, 2026
@dumbbell dumbbell changed the base branch from main to v0.17.x March 19, 2026 18:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (8d0529e) to head (096b413).
⚠️ Report is 2 commits behind head on v0.17.x.

Files with missing lines Patch % Lines
src/khepri_tx_adv.erl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v0.17.x     #377      +/-   ##
===========================================
+ Coverage    90.06%   90.12%   +0.06%     
===========================================
  Files           22       22              
  Lines         3532     3535       +3     
===========================================
+ Hits          3181     3186       +5     
+ Misses         351      349       -2     
Flag Coverage Δ
erlang-26 89.92% <66.66%> (+0.06%) ⬆️
erlang-27 90.09% <66.66%> (+0.06%) ⬆️
erlang-28 90.09% <66.66%> (+0.23%) ⬆️
os-ubuntu-latest 90.12% <66.66%> (+0.23%) ⬆️
os-windows-latest 90.12% <66.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dumbbell dumbbell marked this pull request as ready for review March 19, 2026 18:28
@dumbbell dumbbell merged commit 17f16d8 into v0.17.x Mar 19, 2026
26 checks passed
@dumbbell dumbbell deleted the allow-logger-macros-in-transactions branch March 19, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant