khepri_cluster: Handle exception from trigger_election/2#369
Merged
Conversation
[Why] The underlying call to `gen_statem:call/3` returns errors like `noproc` or a timeout through an exception. We need to handle it in `khepri_cluster`. This was already the case when we start a Ra server, but not during a cluster expansion. [How] We use a try/catch block but we ignore the exception. That's ok because we are already in an error handling code path.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.17.x #369 +/- ##
===========================================
- Coverage 90.09% 90.04% -0.06%
===========================================
Files 22 22
Lines 3523 3525 +2
===========================================
Hits 3174 3174
- Misses 349 351 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The underlying call to
gen_statem:call/3returns errors likenoprocor a timeout through an exception. We need to handle it inkhepri_cluster. This was already the case when we start a Ra server, but not during a cluster expansion.How
We use a try/catch block but we ignore the exception. That's ok because we are already in an error handling code path.