khepri_machine: Improve type specs around machine version and API behaviour#368
Merged
dumbbell merged 3 commits intoMar 11, 2026
Conversation
[Why] This one is simple to document as it controls the only error it can return.
[Why] Be more strict about the `MacVer` argument. This matches the documented type spec.
[Why] It does not help Dialyzer because the type includes any `atom()` and we don't document each individual behaviour here (they are somewhat documented in the machine versions table at the beginning of the module).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.17.x #368 +/- ##
===========================================
+ Coverage 90.17% 90.26% +0.08%
===========================================
Files 22 22
Lines 3523 3523
===========================================
+ Hits 3177 3180 +3
+ Misses 346 343 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dumbbell
deleted the
improve-type-specs-around-machine-version-and-api-behaviour
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of improvements. See individual commits for more details.