khepri_machine: Use initial tree to list sprocs triggered by deletions#357
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.17.x #357 +/- ##
===========================================
+ Coverage 86.26% 86.56% +0.29%
===========================================
Files 22 22
Lines 3517 3521 +4
===========================================
+ Hits 3034 3048 +14
+ Misses 483 473 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dumbbell
requested changes
Feb 3, 2026
Collaborator
dumbbell
left a comment
dumbbell
left a comment
There was a problem hiding this comment.
This looks good to me. Thank you for adding the testcase as well!
Could you please rebase your patch against the v0.17.x branch?
When handling a deletion change, the tree node will certainly not be in the tree after the deletion occurred. So when listing triggered sprocs for deletions we should use the tree as it was before the deletion.
the-mikedavis
force-pushed
the
md/triggers-patterns
branch
from
808f102 to
183a566
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handling a deletion change, the tree node will certainly not be in the tree after the deletion occurred. So when listing triggered sprocs for deletions we should use the tree as it was before the deletion.
Fixes #356. I'm not very familiar with the triggers / sprocs code so I'm not 100% confident in this patch 😅