khepri_machine: Use cached leader for #dedup_ack{}#355
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.17.x #355 +/- ##
===========================================
- Coverage 86.62% 86.55% -0.08%
===========================================
Files 22 22
Lines 3514 3517 +3
===========================================
Hits 3044 3044
- Misses 470 473 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michaelklishin
approved these changes
Jan 28, 2026
the-mikedavis
approved these changes
Jan 28, 2026
dumbbell
requested changes
Feb 3, 2026
Collaborator
dumbbell
left a comment
dumbbell
left a comment
There was a problem hiding this comment.
Could you please rebase your patch on to the v0.17.x branch?
Otherwise, it looks good to me, thank you!
mkuratczyk
force-pushed
the
use-cached-leader
branch
from
ecaa573 to
7f68552
Compare
dumbbell
approved these changes
Feb 3, 2026
[Why]
Everywhere else, we query the cached leader and use it to send a command
directly to it. This optimisation was missing when sending the
`#dedup_ack{}` command.
dumbbell
force-pushed
the
use-cached-leader
branch
from
7f68552 to
c113c67
Compare
dumbbell
changed the title
#dedup_ack{}
dumbbell
force-pushed
the
use-cached-leader
branch
from
c113c67 to
d661fb5
Compare
dumbbell
changed the title
#dedup_ack{}#dedup_ack{}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send the
DedupAckcommand directly to the leader.This prevents forwards that are then logged every time (
follower leader cast - redirecting to ...)