khepri_tree: Ignore keep_while conditions on children on node creation#351
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.17.x #351 +/- ##
===========================================
+ Coverage 86.12% 86.43% +0.30%
===========================================
Files 22 22
Lines 3460 3465 +5
===========================================
+ Hits 2980 2995 +15
+ Misses 480 470 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dumbbell
force-pushed
the
skip-keep_while-on-children-when-parent-created
branch
from
d2f9b90 to
d9d458e
Compare
[Why] If a parent has a `keep_while` condition on a child node, the child node can't possibly exist when the parent is created. Therefore, ignore this condition when the parent is created because it will always be false. [How] Drop `keep_while` conditions on nodes that have the created node as prefix. While here, move this logic to its own function.
dumbbell
force-pushed
the
skip-keep_while-on-children-when-parent-created
branch
from
d9d458e to
2a8e7a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
If a parent has a
keep_whilecondition on a child node, the child node can't possibly exist when the parent is created. Therefore, ignore this condition when the parent is created because it will always be false.How
Drop
keep_whileconditions on nodes that have the created node as prefix.While here, move this logic to its own function.