khepri_cluster: Acquire lock before doing a read/modify/write on ?PT_STORE_IDS#337
Merged
Merged
Conversation
…STORE_IDS [Why] The code was reading the persistent term, adding/removing a key and writing the persistent term again. When several stores are started and/or stopped in parallel, these unprotected concurent read/modify/write operations could cause some store properties to be lost in the process. [How] The code now acquires a local lock before proceeding with this read/modify/write.
dumbbell
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.17.x #337 +/- ##
===========================================
- Coverage 89.59% 89.41% -0.18%
===========================================
Files 22 22
Lines 3430 3439 +9
===========================================
+ Hits 3073 3075 +2
- Misses 357 364 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The code was reading the persistent term, adding/removing a key and writing the persistent term again.
When several stores are started and/or stopped in parallel, these unprotected concurent read/modify/write operations could cause some store properties to be lost in the process.
How
The code now acquires a local lock before proceeding with this read/modify/write.