khepri_machine: Fix query/command options filtering for transactions#327
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 89.29% 89.43% +0.14%
==========================================
Files 22 22
Lines 3326 3342 +16
==========================================
+ Hits 2970 2989 +19
+ Misses 356 353 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[Why]
We used `split_{query,command}_options()` to extract relevant options to
pass to the transaction implementation. However these `split_*()`
functions are strict and they will raise an exception if a query option
is mixed with a command option.
This is impracticle with "auto" transactions that could be queries or
writes.
[How]
In the context of auto transactions, we remove query options before we
extract command options, or the opposite. This way, we are sure the the
`split_*()` function will not raise an exception.
dumbbell
force-pushed
the
fix-option-filtering-on-txs
branch
from
9a0402d to
8b5ba15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We used
split_{query,command}_options()to extract relevant options to pass to the transaction implementation. However thesesplit_*()functions are strict and they will raise an exception if a query option is mixed with a command option.This is impracticle with "auto" transactions that could be queries or writes.
How
In the context of auto transactions, we remove query options before we extract command options, or the opposite. This way, we are sure the the
split_*()function will not raise an exception.